Skip to content

Fix dynamic properties and other problems in tests for PHP 8.2 #35156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
come-nc merged 5 commits into from
Nov 15, 2022
Merged

Fix dynamic properties and other problems in tests for PHP 8.2 #35156

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
70e2217
Fix dynamic properties and other problems in tests for PHP 8.2
come-nc Nov 14, 2022
c79a6b3
Fix errors from PHP 8.2 testing
come-nc Nov 14, 2022
0f7e56b
Fix syntax in VerificationTokenTest.php
come-nc Nov 15, 2022
3241268
Add Union types for properties in tests/lib/Encryption/Keys/StorageTe…
come-nc Nov 15, 2022
72f4b34
Fix tests depending on a trailing whitespace
come-nc Nov 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix tests depending on a trailing whitespace 
Many editors remove trailing whitespaces, so avoid depending on them for
 tests success.

Signed-off-by: Côme Chilliet <[email protected]>
  • Loading branch information
@come-nc
come-nc committed Nov 15, 2022
commit 72f4b34ad5816212fd0f8da374112edcc796b5dc
12 changes: 9 additions & 3 deletions apps/settings/tests/Mailer/NewUserMailHelperTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,9 @@ public function testGenerateTemplateWithPasswordResetToken() {
Install Client: https://nextcloud.com/install/#install-clients


--
EOF;
$expectedTextBody .= "\n-- \n";
$expectedTextBody .= <<<EOF
TestCloud
This is an automatically sent email, please do not reply.
EOF;
Expand Down Expand Up @@ -603,7 +605,9 @@ public function testGenerateTemplateWithoutPasswordResetToken() {
Install Client: https://nextcloud.com/install/#install-clients


--
EOF;
$expectedTextBody .= "\n-- \n";
$expectedTextBody .= <<<EOF
TestCloud
This is an automatically sent email, please do not reply.
EOF;
Expand Down Expand Up @@ -824,7 +828,9 @@ public function testGenerateTemplateWithoutUserId() {
Install Client: https://nextcloud.com/install/#install-clients


--
EOF;
$expectedTextBody .= "\n-- \n";
$expectedTextBody .= <<<EOF
TestCloud
This is an automatically sent email, please do not reply.
EOF;
Expand Down