Skip to content

fix the popovermenu #35484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
szaimen merged 1 commit into from
Nov 30, 2022
Merged

fix the popovermenu #35484

szaimen merged 1 commit into from
Nov 30, 2022

Conversation

@szaimen
Copy link
Contributor

@szaimen szaimen commented Nov 29, 2022 •
edited
Loading

Fix #34653
Fix #35153
Close #34886
Supersedes #34886

Signed-off-by: Simon L [email protected]

For my own testing 
docker run -it \
--name nextcloud-easy-test \
-p 8443:443 \
-e TRUSTED_DOMAIN=192.168.24.128 \
-e SERVER_BRANCH=fix/34653/fix-popover-menu \
--volume="nextcloud_easy_test_npm_cache_volume:/var/www/.npm" \
-e RIGHTCLICK_BRANCH=master \
-e COMPILE_SERVER=1 \
ghcr.io/szaimen/nextcloud-easy-test:latest

@szaimen szaimen added the 2. developing Work in progress label Nov 29, 2022
@szaimen szaimen added this to the Nextcloud 26 milestone Nov 29, 2022
@szaimen szaimen force-pushed the fix/34653/fix-popover-menu branch from 96b20d3 to e11bd0c Compare November 29, 2022 11:38
@szaimen
Copy link
Contributor Author

szaimen commented Nov 29, 2022

/compile amend /

@szaimen szaimen marked this pull request as ready for review November 29, 2022 11:42
@szaimen szaimen changed the title try to fix the popovermenu fix the popovermenu Nov 29, 2022
@szaimen szaimen added bug 3. to review Waiting for reviews and removed 2. developing Work in progress labels Nov 29, 2022
@szaimen szaimen requested review from a team, Pytal, artonge, mejo- and skjnldsv and removed request for a team November 29, 2022 11:43
@szaimen
Copy link
Contributor Author

szaimen commented Nov 29, 2022

/backport to stable25

@szaimen szaimen mentioned this pull request Nov 29, 2022
Closed
9 tasks
mejo-
mejo- approved these changes Nov 29, 2022
View reviewed changes
Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for looking into this @szaimen <3

I didn't test it, but codewise it looks good to me.

@nextcloud-command nextcloud-command force-pushed the fix/34653/fix-popover-menu branch from e11bd0c to c9dc895 Compare November 29, 2022 11:49
@szaimen szaimen force-pushed the fix/34653/fix-popover-menu branch from c9dc895 to a6ac209 Compare November 29, 2022 12:05
@szaimen
Copy link
Contributor Author

szaimen commented Nov 29, 2022

/compile amend /

@szaimen @nextcloud-command
try to fix the popovermenu
f889007 
Signed-off-by: Simon L <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@nextcloud-command nextcloud-command force-pushed the fix/34653/fix-popover-menu branch from a6ac209 to f889007 Compare November 29, 2022 12:37
CarlSchwan
CarlSchwan approved these changes Nov 30, 2022
View reviewed changes
Copy link
Member

@CarlSchwan CarlSchwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@szaimen
Copy link
Contributor Author

szaimen commented Nov 30, 2022

CI failure unrelated

@szaimen szaimen merged commit 415e68f into master Nov 30, 2022
@szaimen szaimen deleted the fix/34653/fix-popover-menu branch November 30, 2022 11:20
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Nov 30, 2022
Merged
1 task
@szaimen szaimen mentioned this pull request Feb 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mejo- mejo- mejo- approved these changes

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@artonge artonge Awaiting requested review from artonge

@Pytal Pytal Awaiting requested review from Pytal

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug

Projects

None yet

Milestone

Nextcloud 26

Development

Successfully merging this pull request may close these issues.

[Bug]: Context menu too narrow for text when triggered from grid view [Bug]: File actions menu links don't span over whole menu width

4 participants

@szaimen @mejo- @CarlSchwan