Skip to content

fix the popovermenu #35484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
szaimen merged 1 commit into from
Nov 30, 2022
Merged

fix the popovermenu #35484

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions apps/files_external/css/settings.css
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion apps/files_external/css/settings.css.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions apps/files_external/css/settings.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@
}
}

#externalStorage .popovermenu li > .menuitem {
width: fit-content !important;
}

#externalStorage td.status {
/* overwrite conflicting core styles */
display: table-cell;
Expand Down
28 changes: 0 additions & 28 deletions core/css/apps.css
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion core/css/apps.css.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

22 changes: 0 additions & 22 deletions core/css/apps.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1208,28 +1208,6 @@ $outter-margin: math.div($popoveritem-height - $popovericon-size, 2);
}
}

/* "app-*" descendants use border-box sizing, so the height of the icon must be
* set to the height of the item (as well as its width to make it squared). */
#content[class*='app-'] {
.bubble,
.app-navigation-entry-menu,
.popovermenu {
li {
> button,
> a,
> .menuitem {
width: fit-content;
/* DEPRECATED! old img in popover fallback
* TODO: to remove */
> img {
width: $popoveritem-height;
height: $popoveritem-height;
}
}
}
}
}

/* CONTENT LIST ------------------------------------------------------------ */
.app-content-list {
position: -webkit-sticky;
Expand Down
Loading