Fix migration to non-empty secret #35600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a fallback for empty keys Signed-off-by: Carl Schwan <[email protected]>
CarlSchwan
requested review from
ArtificialOwl,
come-nc and
icewind1991
and removed request for
a team
szaimen
reviewed
Dec 5, 2022
| $auth->setPassword($this->config->getSystemValue('secret', '')); | ||
| if (!$auth->loadKey($storage->getBackendOption('private_key'))) { | ||
| throw new \RuntimeException('unable to load private key'); | ||
| $auth->setPassword(''); |
Contributor
There was a problem hiding this comment.
Maybe add a comment here why?
szaimen
reviewed
Dec 5, 2022
| $auth->setPassword($this->config->getSystemValue('secret', '')); | ||
| if (!$auth->loadKey($storage->getBackendOption('private_key'))) { | ||
| throw new \RuntimeException('unable to load private key'); | ||
| $auth->setPassword(''); |
Contributor
|
/backport to stable25 |
9 tasks
Signed-off-by: Carl Schwan <[email protected]>
Member
|
obsoleted by #35605 ? @CarlSchwan |
CarlSchwan
added
3. to review
Member
|
seems not obsolete |
PVince81
added
4. to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a fallback for empty keys
Fix #35347
Fix #35443