Skip to content

[stable25] Fix migration to non-empty secret #35616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
PVince81 merged 2 commits into from
Dec 6, 2022
Merged

[stable25] Fix migration to non-empty secret #35616

PVince81 merged 2 commits into from
Dec 6, 2022

Conversation

@CarlSchwan
Copy link
Member

@CarlSchwan CarlSchwan commented Dec 6, 2022

Backport #35600

@CarlSchwan
Fix migration to non-empty secret
40f01de 
Add a fallback for empty keys

Signed-off-by: Carl Schwan <[email protected]>
(cherry picked from commit 754cb58)
@CarlSchwan
Add comments
1c558d2 
Signed-off-by: Carl Schwan <[email protected]>
(cherry picked from commit 5e31ed4)
@CarlSchwan CarlSchwan added this to the Nextcloud 26 milestone Dec 6, 2022
@CarlSchwan CarlSchwan requested a review from a team December 6, 2022 08:02
@CarlSchwan CarlSchwan self-assigned this Dec 6, 2022
@CarlSchwan CarlSchwan requested review from ArtificialOwl, blizzz and icewind1991 and removed request for a team December 6, 2022 08:02
@szaimen szaimen added the 4. to release Ready to be released and/or waiting for tests to finish label Dec 6, 2022
@PVince81
Copy link
Member

PVince81 commented Dec 6, 2022

hard to say if this SMB error is related or not:

<?xml version="1.0" encoding="utf-8"?> <d:error xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns"> <s:exception>Sabre\DAV\Exception\NotAuthenticated</s:exception> <s:message>No 'Authorization: Basic' header found. Either the client didn't send one, or the server is misconfigured, No 'Authorization: Bearer' header found. Either the client didn't send one, or the server is mis-configured</s:message> </d:error>

@PVince81
Copy link
Member

PVince81 commented Dec 6, 2022

as discussed with Carl, this PR would only affect SFTP

@PVince81 PVince81 merged commit 5bc2154 into stable25 Dec 6, 2022
@PVince81 PVince81 deleted the backport/fix/empty-secret-migration-files-external branch December 6, 2022 14:04
@blizzz blizzz mentioned this pull request Dec 6, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@szaimen szaimen szaimen approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@blizzz blizzz Awaiting requested review from blizzz

Assignees

@CarlSchwan CarlSchwan

Labels

4. to release Ready to be released and/or waiting for tests to finish

Projects

None yet

Milestone

Nextcloud 26

Development

Successfully merging this pull request may close these issues.

5 participants

@CarlSchwan @PVince81 @skjnldsv @szaimen