Skip to content

Fix scrolling while dragging in file list view #36024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
artonge merged 1 commit into from
Jan 5, 2023
Merged

Fix scrolling while dragging in file list view #36024

artonge merged 1 commit into from
Jan 5, 2023

Conversation

@artonge
Copy link
Contributor

@artonge artonge commented Jan 5, 2023 •
edited
Loading

Fix #33816

Summary

During the migration from window as the scrolling container to #app-content we forgot to update the remaining of the drag handle function.

This PR fix the scrolling.

Checklist

@artonge artonge added this to the Nextcloud 26 milestone Jan 5, 2023
@artonge artonge self-assigned this Jan 5, 2023
@artonge
Copy link
Contributor Author

artonge commented Jan 5, 2023

/backport to stable25

@artonge artonge force-pushed the artonge/fix/file_list_scroll_while_dragging branch from a087b04 to 2fead4c Compare January 5, 2023 16:18
skjnldsv
skjnldsv approved these changes Jan 5, 2023
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Works!

@artonge artonge force-pushed the artonge/fix/file_list_scroll_while_dragging branch from 2fead4c to 4236ee2 Compare January 5, 2023 16:20
PVince81
PVince81 approved these changes Jan 5, 2023
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice

@PVince81 PVince81 added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 5, 2023
@artonge artonge enabled auto-merge January 5, 2023 16:32
@artonge artonge merged commit c16f593 into master Jan 5, 2023
@artonge artonge deleted the artonge/fix/file_list_scroll_while_dragging branch January 5, 2023 20:35
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jan 5, 2023
Merged
@artonge artonge mentioned this pull request Feb 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PVince81 PVince81 PVince81 approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@mejo- mejo- Awaiting requested review from mejo-

Assignees

@artonge artonge

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feature: files javascript

Projects

None yet

Milestone

Nextcloud 26

Development

Successfully merging this pull request may close these issues.

Dragging files in the file list does not autoscroll

4 participants

@artonge @PVince81 @skjnldsv