Prevent scrolling hover .files-controls #36583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/backport to stable25 |
Contributor
Author
|
/backport to stable24 |
artonge
requested review from
a team,
Pytal,
skjnldsv and
szaimen
and removed request for
a team
artonge
force-pushed
the
artonge/fix/dont_scroll_hover_files-controls
branch
from
63d5b5d to
dccc753
Compare
Pytal
approved these changes
Feb 7, 2023
Signed-off-by: Louis Chemineau <[email protected]>
artonge
force-pushed
the
artonge/fix/dont_scroll_hover_files-controls
branch
from
dccc753 to
47f406b
Compare
Contributor
Author
|
/backport to stable25 |
|
The backport to stable25 failed. Please do this backport manually. |
|
The backport to stable25 failed. Please do this backport manually. |
|
The backport to stable24 failed. Please do this backport manually. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow up of #36024
When dragging a file, it does not make sense to automatically scroll up when hovering the .files-controls header.
This PR makes sure that we do not react when hovering .files-controls.