Skip to content

still include the share target in the cache key for validating share mount #36161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
PVince81 merged 1 commit into from
Jan 16, 2023
Merged

still include the share target in the cache key for validating share mount #36161

PVince81 merged 1 commit into from
Jan 16, 2023

Conversation

@icewind1991
Copy link
Member

@icewind1991 icewind1991 commented Jan 16, 2023

Fixes #36153, alternative for #36159

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Jan 16, 2023
@icewind1991 icewind1991 added this to the Nextcloud 26 milestone Jan 16, 2023
juliusknorr
juliusknorr approved these changes Jan 16, 2023
View reviewed changes
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

PVince81
PVince81 approved these changes Jan 16, 2023
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 mentioned this pull request Jan 16, 2023
Closed
4 tasks
@PVince81
Copy link
Member

PVince81 commented Jan 16, 2023

/backport to stable25

@juliusknorr
Copy link
Member

juliusknorr commented Jan 16, 2023

Text CI running https://github.com/nextcloud/text/actions/runs/3930450707/jobs/6720487571

@PVince81 PVince81 added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 16, 2023
@PVince81 PVince81 mentioned this pull request Jan 16, 2023
Closed
@PVince81 PVince81 merged commit 018a597 into master Jan 16, 2023
@PVince81 PVince81 deleted the bugfix/36153/fix-sharemount-cache-key-include-target branch January 16, 2023 14:25
This was referenced Jan 16, 2023
Merged
Closed
@PVince81
Copy link
Member

PVince81 commented Jan 16, 2023

stable25: #36169
stable24: #36170

This was referenced Jan 16, 2023
Closed
Merged
@kesselb kesselb mentioned this pull request Feb 6, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@PVince81 PVince81 PVince81 approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@come-nc come-nc Awaiting requested review from come-nc

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish

Projects

None yet

Milestone

Nextcloud 26

Development

Successfully merging this pull request may close these issues.

Regression when renaming incoming shares

5 participants

@icewind1991 @PVince81 @juliusknorr @nickvergessen