Skip to content

[stable24] still include the share target in the cache key for validating share mount #36172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
PVince81 merged 1 commit into from
Jan 17, 2023
Merged

[stable24] still include the share target in the cache key for validating share mount #36172

PVince81 merged 1 commit into from
Jan 17, 2023

Conversation

@backportbot-nextcloud
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Jan 16, 2023

backport of #36161

@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 24.0.10 milestone Jan 16, 2023
@PVince81
Copy link
Member

PVince81 commented Jan 16, 2023

too late, you slept for too long, bot

duplicate of #36170

@PVince81 PVince81 closed this Jan 16, 2023
@PVince81 PVince81 mentioned this pull request Jan 16, 2023
Closed
@PVince81
Copy link
Member

PVince81 commented Jan 16, 2023

reopening as #36170 did not trigger CI and I don't want to do more gymnastics

@PVince81 PVince81 reopened this Jan 16, 2023
@blizzz
Copy link
Member

blizzz commented Jan 16, 2023 

1) Test\Avatar\GuestAvatarTest::testGet
--
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-Binary String: 
…

Should be unrelated

@blizzz blizzz added the 4. to release Ready to be released and/or waiting for tests to finish label Jan 16, 2023
@PVince81 PVince81 merged commit eda78c6 into stable24 Jan 17, 2023
@PVince81 PVince81 deleted the backport/36161/stable24 branch January 17, 2023 08:56
@blizzz blizzz mentioned this pull request Jan 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@Pytal Pytal Pytal approved these changes

@come-nc come-nc Awaiting requested review from come-nc

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@PVince81 PVince81 Awaiting requested review from PVince81

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish

Projects

None yet

Milestone

Nextcloud 24.0.9

Development

Successfully merging this pull request may close these issues.

7 participants

@PVince81 @blizzz @nickvergessen @juliusknorr @Pytal @icewind1991