fix(dav): check if principal has email address before accessing it #36210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st3iny
added
bug
3. to review
Member
Author
|
/backport to stable23 |
Member
Author
|
/backport to stable24 |
Member
Author
|
/backport to stable25 |
tcitworld
approved these changes
Jan 18, 2023
Member
Author
|
/backport to stable22 This is needed as per #35021 (comment). The initial feature was also backported to stable22. Ref #21370 (comment) |
ChristophWurst
approved these changes
Jan 18, 2023
ChristophWurst
added
4. to release
Ref nextcloud/calendar#4811 Signed-off-by: Richard Steinmetz <[email protected]>
st3iny
force-pushed
the
fix/4811/principal-email
branch
from
0bab66f to
bbda231
Compare
Member
Author
|
Rebased to fix CI. |
ChristophWurst
approved these changes
Jan 24, 2023
This was referenced Jan 26, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref nextcloud/calendar#4811
Summary
A principal might not have an email address if the user didn't configure one. The existing check is semantically doing the same but throws an exception if the key is missing from the array.
Checklist