Skip to content

[stable24] fix(dav): check if principal has email address before accessing it #36386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
blizzz merged 1 commit into from
Feb 7, 2023
Merged

[stable24] fix(dav): check if principal has email address before accessing it #36386

blizzz merged 1 commit into from
Feb 7, 2023

Conversation

@backportbot-nextcloud
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Jan 26, 2023

backport of #36210

@backportbot-nextcloud backportbot-nextcloud bot added bug feature: caldav Related to CalDAV internals labels Jan 26, 2023
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 24.0.10 milestone Jan 26, 2023
@ChristophWurst ChristophWurst added the 4. to release Ready to be released and/or waiting for tests to finish label Jan 26, 2023
@miaulalala
Copy link
Contributor

miaulalala commented Jan 30, 2023

Drone failure unrelated:

There was 1 failure:
--
1437 |  
1438 | 1) Test\Avatar\GuestAvatarTest::testGet
1439 | Failed asserting that two strings are equal.
1440 | --- Expected
1441 | +++ Actual
1442 | @@ @@
1443 | -Binary String: 0x89504e470d0a1a0a0000000d4948445200000020000000200802000000fc18eda3000000097048597300000ec400000ec401952b0e1b000000bf49444154488963f49cb58881968089a6a68f5a306ac1d0b0808518455cacac62bcdc6882efbe7efff4f327752c309695aa74b643139c77f2dc9a4b57a9630104b4ec3ef8e4c34738f7ddf7efc4e822c182679f3e3d42b2804830382219025899985998100efaf3ef1f952d9818e885cc4d5db5e1e9c7cfd4b460fad1532f3e7f8173df7cf9468c2e122cb8fce2e583771f88570f0123a4a8800013196959017e38f7fedbf74f3e7ea2a60549e646c85c228b0ac6d156c5a805a3160c030b00f4283ddebeb8599a0000000049454e44ae426082
1444 | +Binary String: 0x89504e470d0a1a0a0000000d4948445200000020000000200802000000fc18eda3000000097048597300000ec400000ec401952b0e1b000000be49444154488963f49cb58881968089a6a68f5a306a0155000b91eab85859c578b9d104df7dfdfee9e74fea58602c2b55e96c872638efe4b93597ae52c7020868d97df0c9878f70eebbefdf096a21cd82679f3e3d42b2801830682219025899985998106efaf3ef1f952d9818e885cc4d5db5e1e9c7cfd4b460fad1532f3e7f8173df7cf946500b69165c7ef1f2c1bb0f2469193945050498c848cb0af0c3b9f7dfbe7ff2f113352d48323742e6125354308e56faa3168c5a306a016100000b773dde126d19150000000049454e44ae426082
1445 |  
1446 | /drone/src/tests/lib/Avatar/GuestAvatarTest.php:70

@blizzz blizzz mentioned this pull request Feb 6, 2023
Merged
@blizzz blizzz disabled auto-merge February 7, 2023 17:54
@blizzz blizzz merged commit 7c6a414 into stable24 Feb 7, 2023
@blizzz blizzz deleted the backport/36210/stable24 branch February 7, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@st3iny st3iny st3iny approved these changes

@tcitworld tcitworld tcitworld approved these changes

@miaulalala miaulalala Awaiting requested review from miaulalala

@PVince81 PVince81 Awaiting requested review from PVince81

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feature: caldav Related to CalDAV internals

Projects

None yet

Milestone

Nextcloud 24.0.10

Development

Successfully merging this pull request may close these issues.

6 participants

@miaulalala @ChristophWurst @st3iny @tcitworld @blizzz