fix(dav): catch MaxInstancesExceededException for recurring events without end date #36211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miaulalala
added
bug
3. to review
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
Author
|
/backport to stable25 |
Contributor
Author
|
/backport to stable24 |
…hout end date Ref nextcloud/calendar#4811 Signed-off-by: Anna Larch <[email protected]>
miaulalala
force-pushed
the
enh/catch-recurrence-exception
branch
from
b71b035 to
a9264b0
Compare
tcitworld
approved these changes
Jan 18, 2023
ChristophWurst
approved these changes
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The VEVENT iterator throws a
MaxInstancesExceededExceptionon recurring events that do not have an end date. This exception should be caught and logged as to not break the reminder service.Checklist
Tests (unit, [integration](https://docs.nextcloud.com/server/latest/developer_manual/app_development/tutorial.html#integration-tests), api and/or acceptance) are includedScreenshots before/after for front-end changesDocumentation (manuals or wiki) has been updated or is not required