[stable24] fix(dav): catch MaxInstancesExceededException for recurring events without end date #36234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hout end date Ref nextcloud/calendar#4811 Signed-off-by: Anna Larch <[email protected]>
backportbot-nextcloud
bot
requested review from
ChristophWurst,
miaulalala and
tcitworld
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| $iterator->next(); | ||
| } | ||
| } catch (MaxInstancesExceededException $e) { |
Check failure
Code scanning / Psalm
UndefinedClass
| } | ||
| } catch (MaxInstancesExceededException $e) { | ||
| // Using debug logger as this isn't really an error | ||
| $this->logger->debug('Recurrence with too many instances detected, skipping VEVENT', ['exception' => $e]); |
Check failure
Code scanning / Psalm
UndefinedThisPropertyFetch
| 'id' => $reminder['object_id'], | ||
| ], $reminder['event_hash'], $alarmHash, true, false); | ||
| $this->writeRemindersToDatabase($alarms); | ||
| foreach ($event->VALARM as $valarm) { |
Check notice
Code scanning / Psalm
PossiblyNullIterator
Member
|
If we backport this one to 24 we might as well do the same for #32191 as it will be encountered before. |
Contributor
|
the exception doesn't exist for stable24 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #36211