[stable25] Remove Bootstrap version reference from tooltip.scss #36273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've had some reports that Nextcloud is using an outdated/deprecated Bootstrap version v3.3.5. I believe this to be caused by the string "Bootstrap v3.3.5" in the changed line, which after bundling ends up in `core-common.js`, and trips up some security scanners. It may also be worth investigating why the comments are not getting stripped when bundling the JS. Signed-off-by: Álvaro Brey <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
backportbot-nextcloud
bot
requested review from
AlvaroBrey,
PVince81,
artonge,
come-nc,
nickvergessen,
skjnldsv and
szaimen
nickvergessen
approved these changes
Jan 20, 2023
szaimen
approved these changes
Jan 20, 2023
szaimen
added
the
4. to release
Merged
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #35485