Skip to content

[stable25] Remove Bootstrap version reference from tooltip.scss #36273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 1 commit into from
Jan 20, 2023
Merged

[stable25] Remove Bootstrap version reference from tooltip.scss #36273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Remove Bootstrap version reference from tooltip.scss 
We've had some reports that Nextcloud is using an outdated/deprecated Bootstrap version v3.3.5.

I believe this to be caused by the string "Bootstrap v3.3.5" in the changed line, which after bundling ends up in `core-common.js`, and trips up some security scanners.

It may also be worth investigating why the comments are not getting stripped when bundling the JS.

Signed-off-by: Álvaro Brey <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
  • Loading branch information
@AlvaroBrey @backportbot-nextcloud
AlvaroBrey authored and backportbot-nextcloud[bot] committed Jan 20, 2023
commit 95d5641eb5aa21a16b8b8af7296fa91e0cc60765
2 changes: 1 addition & 1 deletion core/css/server.css
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion core/css/tooltip.css
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion core/css/tooltip.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* @copyright Copyright (c) 2016, Erik Pellikka <[email protected]>
* @copyright Copyright (c) 2015, Vincent Petry <[email protected]>
*
* Bootstrap v3.3.5 (http://getbootstrap.com)
* Bootstrap (http://getbootstrap.com)
* Copyright 2011-2015 Twitter, Inc.
* Licensed under MIT (https://github.com/twbs/bootstrap/blob/master/LICENSE)
*/
Expand Down