Allow empty route for navigation entries

[Pytal]

Summary

Some apps register navigation entries with empty routes e.g.

server/apps/user_status/appinfo/info.xml

Line 18 in 9035be6

<route />

This allows these entries to pass xmllint used in https://github.com/nextcloud/.github/blob/ff4a6f1eacb53e4d3b5721e57743eb64242178a7/workflow-templates/lint-info-xml.yml

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[Pytal]

/backport to stable25

[nickvergessen]

• patch also in appstore, or is it intentionally that only the shipped app file is modified

[nickvergessen]

• patch also in appstore

[nickvergessen]

Instead allowing empty, just allow no occurrences of the route tag?🤔
Sounds easier and more straight forward, but might require additional PHP fallbacks

[Pytal]

Was exactly the initial idea, but because this is needed for #36232 for NC25 accessibility, the minimally invasive solution here prevents the need to backport some potentially breaking changes to i.e. https://github.com/nextcloud/server/blob/ca3f53ab88b06c8ceea5d7991ff40641a9820728/lib/private/NavigationManager.php and https://github.com/nextcloud/server/blob/ca3f53ab88b06c8ceea5d7991ff40641a9820728/lib/private/App/InfoParser.php

[nickvergessen]

Here is the necessary PHP patch:

diff --git a/lib/private/NavigationManager.php b/lib/private/NavigationManager.php
index b78d9fa1ed8..f24a2f0ac25 100644
--- a/lib/private/NavigationManager.php
+++ b/lib/private/NavigationManager.php
@@ -315,7 +315,8 @@ class NavigationManager implements INavigationManager {
 				$id = $nav['id'] ?? $app . ($key === 0 ? '' : $key);
 				$order = isset($nav['order']) ? $nav['order'] : 100;
 				$type = isset($nav['type']) ? $nav['type'] : 'link';
-				$route = $nav['route'] !== '' ? $this->urlGenerator->linkToRoute($nav['route']) : '';
+				$route = $nav['route'] ?? '';
+				$route = $route !== '' ? $this->urlGenerator->linkToRoute($route) : '';
 				$icon = isset($nav['icon']) ? $nav['icon'] : 'app.svg';
 				foreach ([$icon, "$app.svg"] as $i) {
 					try {

[nickvergessen]

• Should also edit https://github.com/nextcloud/server/blob/master/resources/app-info.xsd
• Also edit appstore https://github.com/nextcloud/appstore/blob/d13958626c7a20e33032289e79dab155a967075b/nextcloudappstore/api/v1/release/info.xsd

[nickvergessen]

See comments

[Pytal]

Superseded by #36508