Skip to content

Conversation

@Pytal
Copy link
Member

@Pytal Pytal commented Feb 3, 2023

Summary

Some apps register navigation entries with extraneous empty routes e.g.

Instead of adding empty routes we can allow no routes at all

This adjusts the core logic to allow no route entries and updates the XML schemas to pass xmllint used in https://github.com/nextcloud/.github/blob/ff4a6f1eacb53e4d3b5721e57743eb64242178a7/workflow-templates/lint-info-xml.yml

Checklist

@Pytal
Copy link
Member Author

Pytal commented Feb 3, 2023

/backport to stable25

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🙂

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 3, 2023
@ChristophWurst
Copy link
Member

nit: squash

@nickvergessen
Copy link
Member

No, need visibility for 3 approving people and the author together with the failing CI

@nickvergessen nickvergessen merged commit 7cff390 into master Feb 3, 2023
@nickvergessen nickvergessen deleted the enh/allow-no-route branch February 3, 2023 11:54
@Pytal
Copy link
Member Author

Pytal commented Feb 3, 2023

/backport to stable25

@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Feb 3, 2023

The backport to stable25 failed. Please do this backport manually.

Details
# Switch to the target branch and update it
git checkout stable25
git pull origin/stable25

# Create the new backport branch
git checkout -b fix/foo-stable25

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

#36529

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish feature: settings feature: status

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants