-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Allow settings navigation items with no route entry #36508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Christopher Ng <[email protected]>
- For xmllint Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
|
/backport to stable25 |
ChristophWurst
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🙂
Signed-off-by: Joas Schilling <[email protected]>
|
nit: squash |
|
No, need visibility for 3 approving people and the author together with the failing CI |
|
/backport to stable25 |
|
Details# Switch to the target branch and update it
git checkout stable25
git pull origin/stable25
# Create the new backport branch
git checkout -b fix/foo-stable25
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
Summary
Some apps register navigation entries with extraneous empty routes e.g.
server/apps/user_status/appinfo/info.xml
Line 18 in e81cb6e
Instead of adding empty routes we can allow no routes at all
This adjusts the core logic to allow no route entries and updates the XML schemas to pass
xmllintused in https://github.com/nextcloud/.github/blob/ff4a6f1eacb53e4d3b5721e57743eb64242178a7/workflow-templates/lint-info-xml.ymlChecklist