[F2V] migrate files_trashbin to vue

[skjnldsv]

• Base API
• Fix and update side libraries
• Implement store
  • Fix reactivity issue :(
• Implement initial view
  • Virtual scrolling
  • Table mode
• Selection handling
• Very basic action (without API for now ?)
• Accessibility
• Testing

Needs:

• feat(FileAction): add file action support nextcloud-libraries/nextcloud-files#608
• fix(NcButton): ellipsis text on small width nextcloud-libraries/nextcloud-vue#3936
• fix(NcBreadcrumb): cursor and native title and inline actions rendering text nextcloud-libraries/nextcloud-vue#3927

Follow-up:

• Improve loading indicator for actions
• Deepen virtual scrolling performances
• Implement keyboard arrow/pageUp-Down navigation and focus management
• Hide some columns on small screens

[juliusknorr]

Looks very nice already :) Just some findings, could also be follow ups

• Switching back to other file list does not work once entered the trash bin once
• Previews show a black box
• Restore/delete permanently a file does not remove it from the list
• Grid view is gone
• Breadcrumbs show Foldername.dTIMESTAMP when browsing a deleted folder, in the old implementation we just showed `Foldername
• Sorting by size/name doesn't work yet

[skjnldsv]

• Previews show a black box

You mean when it's loading? Because I do see previews :)

• Restore/delete permanently a file does not remove it from the list

It used to... 🤦
I'll investigate in followup

• Breadcrumbs show Foldername.dTIMESTAMP when browsing a deleted folder, in the old implementation we just showed `Foldername

Yeah, I need to see how I can mitigate this without performance drawback :)

• Sorting by size/name doesn't work yet

Works here! 🤔

Peek.06-04-2023.16-29.mp4

The rest of your points will be followups 😉

[szaimen]

Additionally to Julius' findings, I also found something:

• right-click does not work anymore
• the mobile view is currently completely broken (but already in the top post as I can see)
• clicking on a file in the trashbin downloads the file but with incorrect mimetype ending
• there is at least one warning in the console log when I open the trashbin:
  

Apart from that looks good to me!

[skjnldsv]

@szaimen self signed certificate?
Service workers cannot be loaded on self signed, this is a browser issue.

clicking on a file in the trashbin downloads the file but with incorrect mimetype ending

Can you clarify what do oyou mean with the ending? The extention?
If so this is an issue with the dav backend 😉 (while we could mitigate with the front)
Will open a ticket afterwards 👍

[szaimen]

ending? The extention?

yes I mean the extension.

Downloaded files look like this for example:

[szaimen]

@szaimen self signed certificate?
Service workers cannot be loaded on self signed, this is a browser issue.

Ah I see. Then this is probably a no-issue.

[szaimen]

BTW is there already some chunking implemented so that only a few files are loaded and then only when scrolling further down? (I have not tested this)...

[juliusknorr]

• Previews show a black box

You mean when it's loading? Because I do see previews :)

Still doesn't after retesting. I have the following console trace, that looks related:

PreviewService.ts:30 Uncaught (in promise) ReferenceError: caches is not defined
    at isCachedPreview (PreviewService.ts:30:1)
    at _callee$ (FileEntry.vue?vue&type=script&lang=ts&:269:1)
    at tryCatch (core-common.js:223538:40)
    at Generator.invoke (core-common.js:223773:22)
    at Generator.next (core-common.js:223598:21)
    at asyncGeneratorStep (FileEntry.vue?vue&type=script&lang=ts&:2:1)
    at _next (FileEntry.vue?vue&type=script&lang=ts&:3:1)
    at FileEntry.vue?vue&type=script&lang=ts&:3:1
    at new Promise (<anonymous>)
    at FileEntry.vue?vue&type=script&lang=ts&:3:1

• Sorting by size/name doesn't work yet

Works here! 🤔

Interesting, retested and works now.