-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
feat(files): right click #37669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(files): right click #37669
Conversation
|
First of all thanks for implementing this! :) I've tested this and a few remarks:
|
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
dcee700 to
742e96d
Compare
Signed-off-by: John Molakvoæ <[email protected]>
742e96d to
b7df419
Compare
|
Rebased and ready to review |
|
I can give you an approval if the two points that I mentioned get added to #37627 😉 |
the second is already in this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works and fine by me then :)
(but didnt review the code)
thanks! :) |
|
Does this change affect the "Rename" functionality as well? The focus after clicking "Rename" is out of sorts. |
Implement right click = actions menu open
Reference #37627 #36534