Skip to content

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Apr 11, 2023

Implement right click = actions menu open

Reference #37627 #36534

@skjnldsv skjnldsv added 3. to review Waiting for reviews feature: files labels Apr 11, 2023
@skjnldsv skjnldsv added this to the Nextcloud 27 milestone Apr 11, 2023
@skjnldsv skjnldsv requested a review from a team April 11, 2023 07:32
@skjnldsv skjnldsv self-assigned this Apr 11, 2023
@skjnldsv skjnldsv requested review from Pytal, artonge and szaimen and removed request for a team April 11, 2023 07:32
@szaimen
Copy link
Contributor

szaimen commented Apr 11, 2023

First of all thanks for implementing this! :)

I've tested this and a few remarks:

  • it feels strange that the right-click menu gets opened not directly at the tooltip but at where the expand button is triggered
  • the size and date columns dont have a pointer (the mouse doesnt transform into a pointer)
  • when multi-select is active, shouldn't right clicking show the multi-select options in opup instead of the single file actions?

@skjnldsv

This comment was marked as resolved.

@szaimen

This comment was marked as resolved.

@skjnldsv

This comment was marked as resolved.

@szaimen

This comment was marked as resolved.

@skjnldsv

This comment was marked as resolved.

@skjnldsv skjnldsv force-pushed the feat/files-right-click branch 2 times, most recently from dcee700 to 742e96d Compare April 11, 2023 12:31
Signed-off-by: John Molakvoæ <[email protected]>
@skjnldsv skjnldsv force-pushed the feat/files-right-click branch from 742e96d to b7df419 Compare April 11, 2023 12:39
@skjnldsv
Copy link
Member Author

Rebased and ready to review

@szaimen
Copy link
Contributor

szaimen commented Apr 11, 2023

I can give you an approval if the two points that I mentioned get added to #37627 😉

@skjnldsv
Copy link
Member Author

skjnldsv commented Apr 11, 2023

I can give you an approval if the two points that I mentioned get added to #37627 wink

the second is already in this PR
37627 will be updated with my list later on

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works and fine by me then :)
(but didnt review the code)

@szaimen
Copy link
Contributor

szaimen commented Apr 11, 2023

37627 will be updated with my list later on

thanks! :)

@skjnldsv skjnldsv merged commit 9201742 into master Apr 11, 2023
@skjnldsv skjnldsv deleted the feat/files-right-click branch April 11, 2023 13:47
@damnshaneisthatu
Copy link

Does this change affect the "Rename" functionality as well? The focus after clicking "Rename" is out of sorts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants