Skip to content

fix(client-login-flow): Handle missing stateToken gracefully #36552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ChristophWurst merged 1 commit into from
Feb 6, 2023
Merged

fix(client-login-flow): Handle missing stateToken gracefully #36552

ChristophWurst merged 1 commit into from
Feb 6, 2023

Conversation

@ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Feb 6, 2023 •
edited
Loading

  • Resolves: OC\\Core\\Controller\\ClientFlowLoginV2Controller::grantPage(): Argument #1 ($stateToken) must be of type string, null given

Summary

  1. Open /login/v2/grant

Master: 💥
Here: 😎

TODO

  • Fix

Checklist

@ChristophWurst ChristophWurst added this to the Nextcloud 26 milestone Feb 6, 2023
@ChristophWurst ChristophWurst self-assigned this Feb 6, 2023
@ChristophWurst ChristophWurst merged commit eca7ab3 into master Feb 6, 2023
@ChristophWurst ChristophWurst deleted the fix/client-login-flow/missing-state-token branch February 6, 2023 15:51
@kesselb
Copy link
Contributor

kesselb commented Feb 7, 2023

Hey 👋

I believe #36286 should fix the frontend part.

@ChristophWurst
Copy link
Member Author

ChristophWurst commented Feb 7, 2023

/backport to stable25

This was referenced Feb 7, 2023
Closed
Merged
@ChristophWurst
Copy link
Member Author

ChristophWurst commented Feb 7, 2023

/backport to stable25

@ChristophWurst
Copy link
Member Author

ChristophWurst commented Feb 7, 2023

/backport to stable24

This was referenced Feb 7, 2023
Merged
Merged
@blizzz blizzz mentioned this pull request Feb 9, 2023
Merged
@ChristophWurst ChristophWurst mentioned this pull request Feb 9, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

@julien-nc julien-nc Awaiting requested review from julien-nc

@hamza221 hamza221 Awaiting requested review from hamza221

@Antreesy Antreesy Awaiting requested review from Antreesy

@max-nextcloud max-nextcloud Awaiting requested review from max-nextcloud

+1 more reviewer

@vitormattos vitormattos vitormattos approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ChristophWurst ChristophWurst

Labels

3. to review Waiting for reviews bug integration

Projects

💌 📅 👥 Groupware team
Archived in project

Milestone

Nextcloud 26

Development

Successfully merging this pull request may close these issues.

5 participants

@ChristophWurst @kesselb @vitormattos @juliusknorr