[stable24] fix(client-login-flow): Handle missing stateToken gracefully #36586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backportbot-nextcloud
bot
requested review from
Antreesy,
ChristophWurst,
hamza221,
julien-nc,
juliusknorr,
max-nextcloud and
vitormattos
Merged
Member
|
@ChristophWurst conflicts |
ChristophWurst
force-pushed
the
backport/36552/stable24
branch
from
244f579 to
ba0fbdd
Compare
ChristophWurst
added
3. to review
ChristophWurst
approved these changes
Feb 7, 2023
blizzz
reviewed
Feb 9, 2023
| public function apptokenRedirect(string $stateToken, string $user, string $password) { | ||
| public function apptokenRedirect(?string $stateToken, string $user, string $password) { | ||
| if ($stateToken === null) { | ||
| return $this->loginTokenForbiddenResponse(); |
Member
|
moving to 24.0.11 |
ChristophWurst
force-pushed
the
backport/36552/stable24
branch
from
ba0fbdd to
572f665
Compare
MichaIng
added
2. developing
Member
|
/rebase |
Signed-off-by: Christoph Wurst <[email protected]>
nextcloud-command
force-pushed
the
backport/36552/stable24
branch
from
572f665 to
2b868af
Compare
vitormattos
approved these changes
Mar 3, 2023
MichaIng
approved these changes
Mar 3, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #36552 and #36634