[stable25] Don't regard 1024px width viewport as mobile #36764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backportbot-nextcloud
bot
requested review from
ChristophWurst,
juliusknorr,
max-nextcloud,
mejo-,
raimund-schluessler and
skjnldsv
mejo-
force-pushed
the
backport/36751/stable25
branch
2 times, most recently
from
5e06e63 to
fa10818
Compare
mejo-
approved these changes
Feb 18, 2023
Member
|
/rebase |
Currently we treat 1024px as mobile in some places (e.g. `isMobile` in nextcloud-vue) and as not mobile yet in others (e.g. in mobile.css). This commit changes `mobile.scss` to treat viewports smaller than 1024px as mobile. This PR accompanies nextcloud-libraries/nextcloud-vue#3768 Both are required to fix nextcloud-libraries/nextcloud-vue#3758. Signed-off-by: Jonas <[email protected]>
nextcloud-command
force-pushed
the
backport/36751/stable25
branch
from
fa10818 to
9cf7ed4
Compare
MichaIng
approved these changes
Feb 26, 2023
Member
|
Drone CI errors are unrelated. Maybe someone with superpowers could merge 😬 |
mejo-
added
the
4. to release
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #36751