Skip to content

[stable25] Don't regard 1024px width viewport as mobile #36764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
szaimen merged 1 commit into from
Feb 27, 2023
Merged

[stable25] Don't regard 1024px width viewport as mobile #36764

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Don't regard 1024px width viewport as mobile 
Currently we treat 1024px as mobile in some places (e.g. `isMobile` in
nextcloud-vue) and as not mobile yet in others (e.g. in mobile.css).

This commit changes `mobile.scss` to treat viewports smaller than 1024px
as mobile.

This PR accompanies nextcloud-libraries/nextcloud-vue#3768

Both are required to fix
nextcloud-libraries/nextcloud-vue#3758.

Signed-off-by: Jonas <jonas@freesources.org>
  • Loading branch information
@mejo- @MichaIng
mejo- authored and MichaIng committed Feb 26, 2023
commit 9cf7ed43a1311cfb081c4edb04986b13ff78a0eb
2 changes: 1 addition & 1 deletion core/css/mobile.css
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion core/css/mobile.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
@use 'variables';

@media only screen and (max-width: variables.$breakpoint-mobile) {
@media only screen and (width < variables.$breakpoint-mobile) {

/* position share dropdown */
#dropdown {
Expand Down
2 changes: 1 addition & 1 deletion core/css/server.css
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.