-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
[F2V] favorites view #37727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
[F2V] favorites view #37727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $this->initialState->provideInitialState('storageStats', $storageInfo); | ||
| $this->initialState->provideInitialState('navigation', $navItems); | ||
| $this->initialState->provideInitialState('config', $this->userConfig->getConfigs()); | ||
| $this->initialState->provideInitialState('favoriteFolders', $favElements['folders']); |
Check notice
Code scanning / Psalm
PossiblyUndefinedVariable
Possibly undefined variable $favElements defined in try block
| } | ||
|
|
||
| $f = $this->previewManager->getPreview($file, $x, $y, $a, IPreview::MODE_FILL, $mimeType); | ||
| $f = $this->previewManager->getPreview($file, $x, $y, !$a, IPreview::MODE_FILL, $mimeType); |
Check notice
Code scanning / Psalm
ArgumentTypeCoercion
Argument 1 of OCP\IPreview::getPreview expects OCP\Files\File, but parent type OCP\Files\Node provided
f21fc83 to
a017988
Compare
aea80ff to
88fd21d
Compare
Signed-off-by: John Molakvoæ <[email protected]>
Signed-off-by: John Molakvoæ <[email protected]>
Signed-off-by: John Molakvoæ <[email protected]>
Signed-off-by: John Molakvoæ <[email protected]>
Signed-off-by: John Molakvoæ <[email protected]>
Signed-off-by: John Molakvoæ <[email protected]>
Signed-off-by: John Molakvoæ <[email protected]>
Signed-off-by: John Molakvoæ <[email protected]>
Signed-off-by: John Molakvoæ <[email protected]>
88fd21d to
844f9be
Compare
Member
Author
|
Superseded by #38950 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires:
Fix #7627