Skip to content

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Apr 14, 2023

  • Migrate favorites view
  • Add favorite action
  • Add missing actions
  • Implement webdav prop API

Requires:

Fix #7627

@skjnldsv skjnldsv added this to the Nextcloud 28 milestone Apr 14, 2023
@skjnldsv skjnldsv self-assigned this Apr 14, 2023
@skjnldsv skjnldsv changed the title fix: wrong copyright [f2v] favorites view Apr 14, 2023
$this->initialState->provideInitialState('storageStats', $storageInfo);
$this->initialState->provideInitialState('navigation', $navItems);
$this->initialState->provideInitialState('config', $this->userConfig->getConfigs());
$this->initialState->provideInitialState('favoriteFolders', $favElements['folders']);

Check notice

Code scanning / Psalm

PossiblyUndefinedVariable

Possibly undefined variable $favElements defined in try block
}

$f = $this->previewManager->getPreview($file, $x, $y, $a, IPreview::MODE_FILL, $mimeType);
$f = $this->previewManager->getPreview($file, $x, $y, !$a, IPreview::MODE_FILL, $mimeType);

Check notice

Code scanning / Psalm

ArgumentTypeCoercion

Argument 1 of OCP\IPreview::getPreview expects OCP\Files\File, but parent type OCP\Files\Node provided
Base automatically changed from feat/files-events to master April 14, 2023 09:30
@skjnldsv skjnldsv force-pushed the feat/favorites-vue branch from 88fd21d to 844f9be Compare May 24, 2023 15:07
@skjnldsv skjnldsv changed the title [f2v] favorites view [F2V] favorites view Jun 2, 2023
@skjnldsv skjnldsv mentioned this pull request Jun 22, 2023
3 tasks
@skjnldsv skjnldsv closed this Jul 12, 2023
@skjnldsv
Copy link
Member Author

Superseded by #38950

@skjnldsv skjnldsv deleted the feat/favorites-vue branch August 22, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Add multiple files to favorites

2 participants