Skip to content

Add files actions testing + code coverage #38806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skjnldsv merged 10 commits into from
Jun 21, 2023
Merged

Add files actions testing + code coverage #38806

skjnldsv merged 10 commits into from
Jun 21, 2023

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Jun 14, 2023 •
edited
Loading

  • Sidebar action
  • Delete action
  • Download action
  • Open folder action

Coverage: https://app.codecov.io/gh/nextcloud/server/pull/38806

-----------------------------|---------|----------|---------|---------|-------------------------------------------------------------
File                         | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                                           
-----------------------------|---------|----------|---------|---------|-------------------------------------------------------------
All files                    |   88.39 |    77.14 |   83.92 |    88.7 |                                                             
 apps/dav/src/views          |   70.58 |       50 |   16.66 |   70.58 |                                                             
  CalDavSettings.vue         |   70.58 |       50 |   16.66 |   70.58 | 128-320                                                     
 apps/files/src              |       0 |        0 |       0 |       0 |                                                             
  logger.js                  |       0 |        0 |       0 |       0 |                                                             
 apps/files/src/actions      |     100 |      100 |     100 |     100 |                                                             
  deleteAction.ts            |     100 |      100 |     100 |     100 |                                                             
  downloadAction.ts          |     100 |      100 |     100 |     100 |                                                             
  openFolderAction.ts        |     100 |      100 |     100 |     100 |                                                             
  sidebarAction.ts           |     100 |      100 |     100 |     100 |                                                             
 apps/files/src/services     |   65.95 |    55.88 |   73.33 |    65.9 |                                                             
  FileAction.ts              |   65.95 |    55.88 |   73.33 |    65.9 | 117-121,126,130,134,138,143,147,151,155,159,163,177-178,185 
 apps/files_sharing/src/lib  |     100 |      100 |     100 |     100 |                                                             
  SharePermissionsToolBox.js |     100 |      100 |     100 |     100 |                                                             
 core/src/OC                 |     100 |      100 |     100 |     100 |                                                             
  requesttoken.js            |     100 |      100 |     100 |     100 |                                                             
-----------------------------|---------|----------|---------|---------|-------------------------------------------------------------

@skjnldsv skjnldsv added this to the Nextcloud 28 milestone Jun 14, 2023
@skjnldsv skjnldsv self-assigned this Jun 14, 2023
@skjnldsv skjnldsv force-pushed the feat/f2v/actions-1 branch from 0f6794e to cfc691b Compare June 20, 2023 10:05
@skjnldsv skjnldsv changed the title [wip] fix: delete action import [wip] Add files actions testing Jun 20, 2023
@skjnldsv skjnldsv force-pushed the feat/f2v/actions-1 branch from 408d209 to c9ab5a3 Compare June 20, 2023 14:45
@skjnldsv skjnldsv requested review from a team, Pytal, artonge and susnux and removed request for a team June 20, 2023 14:49
@skjnldsv skjnldsv marked this pull request as ready for review June 20, 2023 14:49
@skjnldsv skjnldsv changed the title [wip] Add files actions testing Add files actions testing Jun 20, 2023
@skjnldsv skjnldsv added 3. to review Waiting for reviews technical debt and removed 2. developing Work in progress labels Jun 20, 2023
@skjnldsv skjnldsv force-pushed the feat/f2v/actions-1 branch from c9ab5a3 to 373be9f Compare June 20, 2023 14:53
@skjnldsv

This comment was marked as resolved.

Sign in to view
artonge
artonge reviewed Jun 20, 2023
View reviewed changes
@skjnldsv skjnldsv requested a review from artonge June 20, 2023 16:31
@skjnldsv skjnldsv mentioned this pull request Jun 2, 2023
Closed
6 tasks
@skjnldsv skjnldsv force-pushed the feat/f2v/actions-1 branch 2 times, most recently from ddf48c4 to 7a7558e Compare June 21, 2023 07:19
@skjnldsv skjnldsv force-pushed the feat/f2v/actions-1 branch from 7a7558e to 45ecd55 Compare June 21, 2023 07:21
@skjnldsv skjnldsv changed the title Add files actions testing Add files actions testing + code coverage Jun 21, 2023
@skjnldsv
chore: update old codecov config
8971148 
Signed-off-by: John Molakvoæ <[email protected]>
@skjnldsv skjnldsv force-pushed the feat/f2v/actions-1 branch from d32a7d1 to 8971148 Compare June 21, 2023 07:28
nickvergessen
nickvergessen reviewed Jun 21, 2023
View reviewed changes
nickvergessen
nickvergessen approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks okay and still renders

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 21, 2023
@skjnldsv skjnldsv merged commit 32bbe3d into master Jun 21, 2023
@skjnldsv skjnldsv deleted the feat/f2v/actions-1 branch June 21, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@artonge artonge artonge approved these changes

@susnux susnux Awaiting requested review from susnux susnux is a code owner automatically assigned from nextcloud/server-frontend

@Pytal Pytal Awaiting requested review from Pytal Pytal is a code owner automatically assigned from nextcloud/server-frontend

Assignees

@skjnldsv skjnldsv

Labels

4. to release Ready to be released and/or waiting for tests to finish feature: files technical debt

Projects

Files to vue
Status: Done

Milestone

Nextcloud 28

Development

Successfully merging this pull request may close these issues.

4 participants

@skjnldsv @nickvergessen @artonge