Skip to content

Fix app overflow menu on bright color theme #38045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusknorr merged 1 commit into from
May 3, 2023
Merged

Fix app overflow menu on bright color theme #38045

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(AppMenu): On bright color theme the app icons in the overflow men… 
…u must be inverted

Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
  • Loading branch information
@susnux @nextcloud-command
susnux authored and nextcloud-command committed May 3, 2023
commit 88f344339d5e87f1e462f7ccab668c8cc48d17ec
14 changes: 10 additions & 4 deletions core/src/components/AppMenu.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,14 +247,18 @@ $header-icon-size: 20px;
}

::v-deep .app-menu-more .button-vue--vue-tertiary {
color: var(--color-primary-text);
opacity: .7;
margin: 3px;
filter: var(--background-image-invert-if-bright);

&:hover {
opacity: 1;
background-color: transparent !important;
/* Remove all background and align text color if not expanded */
&:not([aria-expanded="true"]) {
color: var(--color-primary-text);

&:hover {
opacity: 1;
background-color: transparent !important;
}
}

&:focus-visible {
Expand All @@ -267,6 +271,8 @@ $header-icon-size: 20px;
.app-icon {
position: relative;
height: 44px;
/* Icons are bright so invert them if bright color theme == bright background is used */
filter: var(--background-invert-if-bright);

&.has-unread::after {
background-color: var(--color-main-text);
Expand Down
4 changes: 2 additions & 2 deletions dist/core-main.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/core-main.js.map
View file
Open in desktop

Large diffs are not rendered by default.