[stable25] Add required accessibility attributes to legacy files navigation #38074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Member
|
Thanks @susnux! I believe we don't need to do this for 25, can you confirm @AndyScherzinger? |
Member
|
Can confirm, having it for the versions above as described by @susnux would be enough |
JuliaKirschenheuter
approved these changes
May 5, 2023
Contributor
Author
|
/compile amend |
nextcloud-command
force-pushed
the
stable25-fix-a11y-files-settings
branch
from
722ac00 to
f128bab
Compare
Contributor
Author
Are there any objections to fix this for NC25 / merge? (As the work is already done 😅 ) |
Member
skjnldsv
approved these changes
May 9, 2023
skjnldsv
reviewed
May 9, 2023
Co-authored-by: John Molakvoæ <[email protected]> Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
stable25-fix-a11y-files-settings
branch
from
698f97b to
8f2f886
Compare
susnux
added
4. to release
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The files settings button on the app navigation is an accordion button for NC25, so it requires some additional accessibility attributes to be set.
Checklist