Skip to content

[stable25] Add required accessibility attributes to legacy files navigation #38074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blizzz merged 1 commit into from
May 17, 2023
Merged

[stable25] Add required accessibility attributes to legacy files navigation #38074

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add required accessibility attributes to legacy files navigation 
Co-authored-by: John Molakvoæ <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
  • Loading branch information
@susnux @skjnldsv
susnux and skjnldsv committed May 15, 2023
commit 8f2f886411eae6e78d0102684ab71594a2a9bea9
1 change: 1 addition & 0 deletions apps/files/src/files-app-settings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ window.addEventListener('DOMContentLoaded', function() {
appSettingsHeader.addEventListener('click', e => {
const opened = e.currentTarget.children[0].classList.contains('opened')
OCA.Files.Settings.settings.forEach(e => opened ? e.close() : e.open())
e.currentTarget?.children?.[0]?.setAttribute?.('aria-expanded', opened ? 'false' : 'true')
})
}
})
4 changes: 3 additions & 1 deletion apps/files/templates/appnavigation.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,13 @@
<div id="app-settings">
<div id="app-settings-header">
<button class="settings-button"
aria-expanded="false"
aria-controls="app-settings-content"
data-apps-slide-toggle="#app-settings-content">
<?php p($l->t('Files settings')); ?>
</button>
</div>
<div id="app-settings-content">
<div id="app-settings-content" role="region" aria-labelledby="app-settings-header">
<div id="files-app-settings"></div>
<div id="files-setting-showhidden">
<input class="checkbox" id="showhiddenfilesToggle"
Expand Down
Loading