Use aria-expanded correctly on toggle user actions #38294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfebe
requested review from
a team,
ArtificialOwl,
artonge,
blizzz and
icewind1991
and removed request for
a team
artonge
approved these changes
May 16, 2023
nfebe
force-pushed
the
fix/37137/add-aria-expanded-to-toggler-user-options
branch
from
e106982 to
68a1557
Compare
Merged
nfebe
force-pushed
the
fix/37137/add-aria-expanded-to-toggler-user-options
branch
from
68a1557 to
dc16821
Compare
susnux
approved these changes
May 17, 2023
Contributor
Author
|
/backport to stable26 |
Contributor
Author
|
/backport to stable25 |
Contributor
Author
|
/compile amend / |
The aria-expanded attribute was added on the expandable item rather Than the button that triggers the expand. Resolves : #37137 Signed-off-by: fenn-cs <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
nextcloud-command
force-pushed
the
fix/37137/add-aria-expanded-to-toggler-user-options
branch
from
dc16821 to
a39f0de
Compare
This was referenced May 18, 2023
Member
|
/backport to stable27 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aria-expanded attribute was added on the expandable item rather Than the button that triggers the expand.
Resolves : #37137