Skip to content

Share api expanded by tags #3876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rullzer merged 1 commit into from
Apr 11, 2017
Merged

Share api expanded by tags #3876

rullzer merged 1 commit into from
Apr 11, 2017

Conversation

@MorrisJobke
Copy link
Member

@MorrisJobke MorrisJobke commented Mar 16, 2017

@rullzer @schiessle I adjusted the downstream to the new location of the sharing code.

@MorrisJobke MorrisJobke added this to the Nextcloud 12.0 milestone Mar 16, 2017
@mention-bot
Copy link

mention-bot commented Mar 16, 2017

@MorrisJobke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rullzer, @icewind1991 and @schiessle to be potential reviewers.

@MorrisJobke MorrisJobke force-pushed the downstream-26583 branch 2 times, most recently from 16b945f to 3294a82 Compare March 22, 2017 22:15
@MorrisJobke
Copy link
Member Author

MorrisJobke commented Mar 22, 2017

I rebased to resolve a conflict

@MorrisJobke
Copy link
Member Author

MorrisJobke commented Mar 22, 2017

👍 from me on this

rullzer
rullzer approved these changes Mar 29, 2017
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm stll not very happy with this. But I see no (or rather don't have time for) a better way.

@jancborchardt you can be happy...

rullzer
rullzer previously requested changes Mar 29, 2017
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mmmm it seem the data is not properly re-requested....

@rullzer
Copy link
Member

rullzer commented Mar 29, 2017

Rather rerendered.

Steps:

  1. share a file as favorite
  2. share that file to somebody
  3. go to shared by me
  4. go to shared with me
  5. go to shared by me

The result is that the list is not rerendered....

@rullzer rullzer added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Mar 30, 2017
@rullzer
Copy link
Member

rullzer commented Apr 11, 2017

Once #4293 is in this should be good to go as well... Will rebase after that.

@mjobst-necls @MorrisJobke
share api expanded by tags (#26583)
81b1dc4 
* share api expanded by tags

* Modified files_sharing JS Unit tests

* modified tests. renamed request parameter. refactoring

* Update Share20OCS.php

Added missing function description

* Update Helper.php

Added missing function description

* Update Helper.php

implicit boolean conversion to !empty()

* Update Share20OCSTest.php

Signed-off-by: Morris Jobke <[email protected]>
@MorrisJobke
Copy link
Member Author

MorrisJobke commented Apr 11, 2017

Once #4293 is in this should be good to go as well... Will rebase after that.

Rebased.

@MorrisJobke
Copy link
Member Author

MorrisJobke commented Apr 11, 2017

I tested it and it works properly 👍

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Apr 11, 2017
@rullzer rullzer merged commit 53ac842 into master Apr 11, 2017
@rullzer rullzer deleted the downstream-26583 branch April 11, 2017 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@schiessle schiessle Awaiting requested review from schiessle

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish feature: sharing

Projects

None yet

Milestone

Nextcloud 12.0

Development

Successfully merging this pull request may close these issues.

5 participants

@MorrisJobke @mention-bot @rullzer @mjobst-necls