Skip to content

Do reload shared views #4293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MorrisJobke merged 1 commit into from
Apr 11, 2017
Merged

Do reload shared views #4293

MorrisJobke merged 1 commit into from
Apr 11, 2017

Conversation

@rullzer
Copy link
Member

@rullzer rullzer commented Apr 11, 2017

Fixes #4248

The magic introduced in #3686 caused the shared views not to be updated
properly. Thus we just overwrite the _onUrlChange method in the
sharedfilelist.

To test:

  1. Create a folder foo
  2. Share that folder
  3. Navigate to Shared with others
  4. Navigate to Shared with you
  5. Navigate to Shared with others

Before: empty
Now: not empty

@rullzer
Do reload shared views
8c01e45 
Fixes #4248

The magic introduced in #3686 caused the shared views not to be updated
properly. Thus we just overwrite the _onUrlChange method in the
sharedfilelist.

Signed-off-by: Roeland Jago Douma <[email protected]>
@rullzer rullzer added this to the Nextcloud 12.0 milestone Apr 11, 2017
@mention-bot
Copy link

mention-bot commented Apr 11, 2017

@rullzer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @MorrisJobke, @Xenopathic and @schiessle to be potential reviewers.

@rullzer rullzer requested a review from ChristophWurst April 11, 2017 07:37
@rullzer rullzer mentioned this pull request Apr 11, 2017
Closed
ChristophWurst
ChristophWurst approved these changes Apr 11, 2017
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected now

@rullzer rullzer mentioned this pull request Apr 11, 2017
Merged
MorrisJobke
MorrisJobke approved these changes Apr 11, 2017
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke MorrisJobke merged commit 45a6e37 into master Apr 11, 2017
@MorrisJobke MorrisJobke deleted the fix_4248 branch April 11, 2017 16:53
@icewind1991 icewind1991 mentioned this pull request Apr 21, 2017
Merged
@danxuliu danxuliu mentioned this pull request Oct 21, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@LukasReschke LukasReschke Awaiting requested review from LukasReschke

@icewind1991 icewind1991 Awaiting requested review from icewind1991

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug feature: files feature: sharing

Projects

None yet

Milestone

Nextcloud 12.0

Development

Successfully merging this pull request may close these issues.

5 participants

@rullzer @mention-bot @MorrisJobke @ChristophWurst