Refactor "substr" calls in lib/private to improve code readability #39216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hamid Dehnavi <[email protected]>
shdehnavi
changed the title
fsamapoor
approved these changes
Jul 20, 2023
Member
fsamapoor
left a comment
fsamapoor
left a comment
There was a problem hiding this comment.
Much much better. Thanks!
Other than the comment I left, looks good to me.
Co-authored-by: Faraz Samapoor <[email protected]> Signed-off-by: Hamid Dehnavi <[email protected]>
artonge
approved these changes
Aug 17, 2023
Co-authored-by: Louis <[email protected]> Signed-off-by: Hamid Dehnavi <[email protected]>
come-nc
requested changes
Sep 5, 2023
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Co-authored-by: Côme Chilliet <[email protected]> Signed-off-by: Hamid Dehnavi <[email protected]>
come-nc
approved these changes
Sep 7, 2023
icewind1991
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replacing
substrwithstr_starts_withandstr_ends_within the/lib/privatenamespace to improve code readabilityChecklist