Skip to content

Refactor "substr" calls in lib/private to improve code readability #39216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
icewind1991 merged 4 commits into from
Sep 21, 2023
Merged

Refactor "substr" calls in lib/private to improve code readability #39216

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d0b2053
Refactor "substr" calls to improve code readability
shdehnavi Jul 7, 2023
495683c
Make adjustments based on the review
shdehnavi Jul 20, 2023
9b92c1a
Update lib/private/DateTimeFormatter.php
shdehnavi Sep 5, 2023
0808e19
Update lib/private/DateTimeFormatter.php
shdehnavi Sep 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make adjustments based on the review 
Co-authored-by: Faraz Samapoor <[email protected]>
Signed-off-by: Hamid Dehnavi <[email protected]>
  • Loading branch information
@shdehnavi @fsamapoor
shdehnavi and fsamapoor committed Jul 20, 2023
commit 495683c358af560684a9f96cd54ec27744d55146
2 changes: 1 addition & 1 deletion lib/private/DateTimeFormatter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ public function formatDate($timestamp, $format = 'long', \DateTimeZone $timeZone
* @return string Formatted relative date string
*/
public function formatDateRelativeDay($timestamp, $format = 'long', \DateTimeZone $timeZone = null, \OCP\IL10N $l = null) {
if (!str_ends_with($format, '*') && !str_ends_with($format, '*')) {
if (!str_ends_with($format, '*')) {
$format .= '^';
}

Expand Down