Bump CS Fixer rules to follow latest Nextcloud standards #39271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
come-nc
reviewed
Jul 17, 2023
Contributor
come-nc
left a comment
come-nc
left a comment
There was a problem hiding this comment.
I think you should also change platform to php: 8.0 in the same composer.json file
Contributor
|
It seems CI is checking all files so you will have to run |
Altahrim
force-pushed
the
bump-coding-standards
branch
from
341f141 to
549853e
Compare
come-nc
reviewed
Jul 18, 2023
Altahrim
force-pushed
the
bump-coding-standards
branch
2 times, most recently
from
5d8d31b to
f71689f
Compare
Altahrim
requested review from
CarlSchwan,
ChristophWurst,
miaulalala,
nickvergessen and
st3iny
as code owners
nickvergessen
requested changes
Jul 18, 2023
Altahrim
force-pushed
the
bump-coding-standards
branch
from
f71689f to
5b80a28
Compare
Altahrim
added
3. to review
nickvergessen
approved these changes
Jul 18, 2023
come-nc
approved these changes
Jul 18, 2023
Altahrim
force-pushed
the
bump-coding-standards
branch
from
5b80a28 to
fd1e6da
Compare
Altahrim
added
4. to release
Contributor
|
@skjnldsv You’ve put milestone 29 for this on purpose? Does it mean we should wait for 28 branch off before merging? |
6 tasks
Member
The current idea is to do and merge it directly before the branch-off to break as few PRs as possible and to be still able to somewhat normally use the backport bot to stable28 then |
come-nc
requested changes
Sep 26, 2023
13 tasks
Altahrim
force-pushed
the
bump-coding-standards
branch
2 times, most recently
from
3c76d84 to
bb941d1
Compare
4 tasks
lib/composer/bamarni/composer-bin-plugin/.github/workflows/phpstan.yml
Outdated
Show resolved
Hide resolved
Altahrim
force-pushed
the
bump-coding-standards
branch
from
bb941d1 to
82190ac
Compare
Member
|
Now is the time |
Member
|
rebasing with dropping the |
nickvergessen
force-pushed
the
bump-coding-standards
branch
from
82190ac to
f33efe8
Compare
nickvergessen
requested review from
provokateurin and
tcitworld
as code owners
nickvergessen
force-pushed
the
bump-coding-standards
branch
from
f33efe8 to
c5bcc4b
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
blizzz
approved these changes
Nov 23, 2023
Signed-off-by: Benjamin Gaussorgues <[email protected]>
…red itself Signed-off-by: Joas Schilling <[email protected]> Signed-off-by: Benjamin Gaussorgues <[email protected]>
Signed-off-by: Joas Schilling <[email protected]> Signed-off-by: Benjamin Gaussorgues <[email protected]>
Altahrim
force-pushed
the
bump-coding-standards
branch
from
c5bcc4b to
aa5f037
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update PHP CS coding standards to lastest Nextcloud standards