Skip to content

Conversation

@juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Jul 14, 2023

Backport of #39389
Required for nextcloud/text#4521

@juliusknorr juliusknorr added bug 2. developing Work in progress labels Jul 14, 2023
@juliusknorr juliusknorr added this to the Nextcloud 27.0.1 milestone Jul 14, 2023
@juliusknorr juliusknorr added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 17, 2023
Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look legit when compared with the original PR.

Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look sensible when compared to the original PR.

@juliusknorr
Copy link
Member Author

Psalm also fails unrelated on the base branch

@juliusknorr juliusknorr merged commit 83f7ea0 into stable27 Jul 17, 2023
@juliusknorr juliusknorr deleted the backport/39389/stable27 branch July 17, 2023 09:26
@blizzz blizzz mentioned this pull request Jul 17, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants