Skip to content

fix: Add index to session_id on text_steps table #4521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
juliusknorr merged 2 commits into from
Jul 14, 2023
Merged

fix: Add index to session_id on text_steps table #4521

juliusknorr merged 2 commits into from
Jul 14, 2023

Conversation

@juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Jul 14, 2023 •
edited
Loading

Adds the missing index from #4339

Fixes #4522

Requires nextcloud/server#39389

Static failure expected as the server PR is not there yet

@juliusknorr juliusknorr mentioned this pull request Jul 14, 2023
Merged
5 tasks
@juliusknorr juliusknorr force-pushed the bugfix/noid/add-missing-index-steps branch from 936014a to 57db17e Compare July 14, 2023 09:02
@juliusknorr juliusknorr marked this pull request as ready for review July 14, 2023 09:07
@juliusknorr juliusknorr added bug Something isn't working 3. to review high labels Jul 14, 2023
@juliusknorr juliusknorr added this to the Nextcloud 28 milestone Jul 14, 2023
nickvergessen
nickvergessen approved these changes Jul 14, 2023
View reviewed changes
@juliusknorr juliusknorr force-pushed the bugfix/noid/add-missing-index-steps branch from 57db17e to e936863 Compare July 14, 2023 09:25
@cypress
Copy link

cypress bot commented Jul 14, 2023 •
edited
Loading

2 flaky tests on run #11103 ↗︎

0 149 2 0 Flakiness 2

Details:

fix: Add index to session_id on text_steps table
Project: Text Commit: b953ddb627
Status: Passed Duration: 03:56 💡
Started: Jul 14, 2023 12:36 PM Ended: Jul 14, 2023 12:40 PM
Flakiness  cypress/e2e/propfind.spec.js • 2 flaky tests

View Output Video

Test Artifacts
Text PROPFIND extension > with workspaces enabled > adds rich workspace property to nested folders Output Screenshots
Text PROPFIND extension > with workspaces disabled > does not return a rich workspace property Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@juliusknorr juliusknorr merged commit 79aa84b into main Jul 14, 2023
@juliusknorr juliusknorr deleted the bugfix/noid/add-missing-index-steps branch July 14, 2023 14:24
@juliusknorr
Copy link
Member Author

juliusknorr commented Jul 14, 2023

/backport e936863 to stable27

@juliusknorr
Copy link
Member Author

juliusknorr commented Jul 14, 2023

/backport e936863 to stable26

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jul 14, 2023
Merged
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jul 14, 2023
Merged
This was referenced Jul 14, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@blizzz blizzz blizzz approved these changes

@luka-nextcloud luka-nextcloud Awaiting requested review from luka-nextcloud

@Hephi2 Hephi2 Awaiting requested review from Hephi2

Assignees

No one assigned

Labels

3. to review bug Something isn't working high

Projects

None yet

Milestone

Nextcloud 28

Development

Successfully merging this pull request may close these issues.

Slow query on 27.0.1 RC1

4 participants

@juliusknorr @nickvergessen @blizzz