-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
feat(files): add sharing icon in header #40192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
28b3070 to
52590a7
Compare
7f04a0a to
6a91fa3
Compare
This comment was marked as resolved.
This comment was marked as resolved.
|
@szaimen Feel free to open an issue, but for now this is feature parity. EDIT: Unless you can get to an agreement with the design team before it's merged. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
6a91fa3 to
088a382
Compare
Here you go, we now have exactly what we had on the old files app. |
|
I created #40202 |
|
I tested this and the icon does not seem to directly update after I shared the folder for example. I guess this should be the case though? Apart from that seems to work well so good work! |
Needs a separate fix. We'll need to do a pass on global events. But right now the Sidebar doesn't update the files store, you are correct :) |
Signed-off-by: John Molakvoæ <[email protected]>
Signed-off-by: John Molakvoæ <[email protected]>
088a382 to
2592568
Compare
Shall I create a follow-up issue then? |
lhsazevedo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working well for me as well
I've created #40263 |
szaimen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay for me then for now
Uh oh!
There was an error while loading. Please reload this page.