Fix sharing icon

[marcoambrosini]

• Resolves: adjust icon of shared state in broadcrumb #40202

Summary

shared state

unshared state

TODO

• ...

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[skjnldsv]

Seems like the first icon on your screenshot isn't what is being discussed on the mentioned issue: #40202
I fear we don't use that icon anywhere else :)

[skjnldsv]

@jancborchardt shall we lose the share link icon too?

[jancborchardt]

If it’s shared by link, that should be reflected?

[skjnldsv]

I agree, but this PR removes that

[marcoambrosini]

@jancborchardt we said in yesterday's design review that we're not going to use this icon in iOS in favor of the native one. I think that in line with that, we should use the material folder-shared icon that @szaimen proposed in the issue both in the web interface and in the android apps.

[marcoambrosini]

Seems like the first icon on your screenshot isn't what is being discussed on the mentioned issue: #40202

I see now that @jancborchardt refers to the folder with the link in it. I think that the folder-share material design icon is more appropriate, both here and in the files list.

[jancborchardt]

@marcoambrosini @skjnldsv let’s indeed focus on the issue at hand here to prevent creating deadlocks like these. :)

This icon https://fonts.google.com/icons?selected=Material%20Icons%3Aperson_add_alt_1%3A communicates both "Share" and "Add to share", so it can be used in both unshared and shared state, which we currently do not separate in the breadcrumbs either.

[szaimen]

this should probably be restored?

[skjnldsv]

#42502 (comment)

[marcoambrosini]

let’s indeed focus on the issue at hand

The issue at hand proposes the usage of this new icon @jancborchardt

which we currently do not separate in the breadcrumbs either.

We currently have separate states in the breadcrumbs icon, just with a worse logic. A different icon is shown only if the folder is shared by link. No distinction is made between unshared and shared without link.
I think it's just better to distinguish between shared and not shared.
Ref #40192

[jancborchardt]

So as @skjnldsv said, we don’t use the proposed icon anywhere. What we do use is these ones:

The core issue is mainly that in the breadcrumbs we still use the "triangle" share icon, and that needs to be replaced. If we discuss more than that then it will of course lead to unnecessary discussion and block a simple fix as this → so let’s keep the matters separate.

[jancborchardt]

Moving assignment from @marcoambrosini to @szaimen as discussed in the design team call. :)

[szaimen]

Superceded by #43433