No prefetch in "stream_open()" [SFTP] #40459
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"$this->request_chunk(256 * 1024);" at the end of "stream_open()" fetches a chunk of file contents. But when "stream_close()" is called without calling "stream_read()", it tries to read status code from "request_chunk()". Which lead to stream_close() to return false. After this, regular files are displayed as folders. Previews are not generated. Instead of fetching chunk in "stream_open()", make the "stream_read()" call both "request_chunk()" and "read_chunk()" it it. Issue #25788 Signed-off-by: Rae Kim <[email protected]>
szaimen
requested review from
a team,
come-nc,
icewind1991 and
nfebe
and removed request for
a team
8 tasks
joshtrichards
changed the title
Member
|
/update-3rdparty/ |
Member
|
#40183 fixes the same "close error" while maintaining the pre-fetch performance benefits. |
Author
|
@icewind1991 Great. Let me close this one. Thank you for the fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
$this->request_chunk(256 * 1024)at the end ofstream_open()fetches a chunk of file contents. But whenstream_close()is called without callingstream_read(), it tries to read status code fromrequest_chunk(). Which lead tostream_close()to returnfalse.After this, regular files are displayed as folders. Previews are not generated.
Instead of fetching chunk in
stream_open(), make thestream_read()call bothrequest_chunk()andread_chunk()it it.TODO
Checklist