Fix small previews with Imaginary #40670
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This solves #38911 cc @szaimen @solracsf Signed-off-by: Daniel Hansson <[email protected]>
Member
Author
|
Please backport to stable27, backport bot didn't like my efforts. |
Member
|
@Glandos maybe you can review here, after your last changes? |
szaimen
changed the title
szaimen
requested review from
a team,
ArtificialOwl,
icewind1991 and
nfebe
and removed request for
a team
Contributor
|
Given the small change involved, I think everything will be OK. However, I'm sorry to say that I don't have time right now to investigate more than that 😢 |
Member
Author
|
OK to merge? |
Contributor
|
maybe we should revisit this due to #38911 (comment)? |
Member
Author
Better to put that in a separate PR IMHO, this fixes the bug, then performance is another topic. But sure, it's an easy fix if the decision is to remove it. |
enoch85
added a commit
that referenced
this pull request
Sep 30, 2023
A follow up on #40670 Based on discussions here: #38911 (comment) This fixes the case were not all previews are generated, for example in the activity view: #38911 (comment) Signed-off-by: Daniel Hansson <[email protected]>
5 tasks
nfebe
pushed a commit
that referenced
this pull request
Oct 9, 2023
A follow up on #40670 Based on discussions here: #38911 (comment) This fixes the case were not all previews are generated, for example in the activity view: #38911 (comment) Signed-off-by: Daniel Hansson <[email protected]>
zak39
pushed a commit
to zak39/server
that referenced
this pull request
Dec 19, 2023
A follow up on nextcloud#40670 Based on discussions here: nextcloud#38911 (comment) This fixes the case were not all previews are generated, for example in the activity view: nextcloud#38911 (comment) Signed-off-by: Daniel Hansson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #38911 (comment)
Summary
Without this change PDF, TIF and some other formats aren't generated if Imaginary is used.
Checklist