Generate all preview sizes for Imaginary

[enoch85]

Based on discussions here: #38911 (comment)

This fixes the case were not all previews are generated, for example in the activity view: #38911 (comment)

• Resolves: #
  [Bug]: PDF previews don't work after upgrade to 27 - Error 400 #38911

Summary

TODO

• ...

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[enoch85]

FWIW, just tested this with a client that had 1000s of PDFs, everything is super fast and it generates everything.

I think we should close the other PR, let's have a vote. 👎 for no, and 👍 for keeping it. gogogo

[Chartman123]

Just go on and close it... The other fix would be lost by merging this here ;)

[enoch85]

Just go on and close it... The other fix would be lost by merging this here ;)

Done, but you should have voted 👎 ;)

[szaimen]

Tested by the community and confirmed to make things work but cannot judge the code changes

[enoch85]

@juliushaertl Would you mind having a look at this? It removes a function which makes everything work again.

[ChristophWurst]

(partly) reverts the changes from #31864 so 👀 @skjnldsv

[nfebe]

I am skeptical about deleting the performance related previews all together, the real question is *why does the deleted snippet or getSmallImagePreview not generate the previews?

Theoretically we should be able to generate smaller previews no?

[enoch85]

I am skeptical about deleting the performance related previews all together, the real question is what does the deleted snippet or getSmallImagePreview to generate the previews?

Theoretically we should be able to generate smaller previews no?

The function is buggy and doesn't make a huge impact when used.

Ok, if you're on a Raspberry Pi or some legacy hardware - sure, but not for the "normal" user of Nextcloud and certainly not Enterprise users.

[enoch85]

/backport to stable27

[backportbot-nextcloud]

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

[enoch85]

@fenn-cs Can you please help me with the backport?

[nfebe]

Sure @enoch85 would look into it.

[solracsf]

/backport b2d105e to stable27