fix(JobList#hasReservedJob): Break tie when multiple jobs are reserved #41295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcel Klehr <[email protected]>
marcelklehr
requested review from
a team,
ArtificialOwl,
come-nc and
icewind1991
and removed request for
a team
Member
Author
|
/backport to stable27 |
miaulalala
approved these changes
Nov 6, 2023
nickvergessen
approved these changes
Nov 8, 2023
Member
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
Worth to put into the comment of the method/interface (public api)
Signed-off-by: Marcel Klehr <[email protected]>
Member
Author
|
Done. CI failures seem unrelated. Please merge. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, when multiple jobs of the same class are reserved that have all set allowParallelRuns to false, none of them will run. This changes the check to only consider the jobs reserved in the past 6h as currently running.
Checklist