Skip to content

fix(JobList#hasReservedJob): Break tie when multiple jobs are reserved #41295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 2 commits into from
Nov 9, 2023
Merged

fix(JobList#hasReservedJob): Break tie when multiple jobs are reserved #41295

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cbd304c
fix(JobList#hasReservedJob): Break tie when multiple jobs are reserved
marcelklehr Nov 6, 2023
1471849
fix: Extend docblock of hasReservedJob
marcelklehr Nov 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/private/BackgroundJob/JobList.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,7 @@ public function hasReservedJob(?string $className = null): bool {
$query = $this->connection->getQueryBuilder();
$query->select('*')
->from('jobs')
->where($query->expr()->neq('reserved_at', $query->createNamedParameter(0, IQueryBuilder::PARAM_INT)))
->where($query->expr()->gt('reserved_at', $query->createNamedParameter($this->timeFactory->getTime() - 6 * 3600, IQueryBuilder::PARAM_INT)))
->setMaxResults(1);

if ($className !== null) {
Expand Down