Skip to content

Conversation

@SystemKeeper
Copy link
Contributor

Summary

To support call sounds in Safari we need to use *.flac audio files, since *.ogg is not supported by Safari (nextcloud/spreed#9422). But currently *.flac files will not be served, so

https://.../apps/spreed/img/join_call.ogg -> works
https://.../apps/spreed/img/join_call.flac -> does not work

Since we added call sounds with 27, backport to stable27?

Checklist

Signed-off-by: Marcel Müller <[email protected]>
@SystemKeeper SystemKeeper requested review from a team, Altahrim, ArtificialOwl, nickvergessen and sorbaugh and removed request for a team November 16, 2023 13:28
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update the nginx docs:
https://docs.nextcloud.com/server/stable/admin_manual/installation/nginx.html

    # Serve static files
    location ~ \.(?:css|js|mjs|svg|gif|png|jpg|ico|wasm|tflite|map)$ {

And add to https://docs.nextcloud.com/server/stable/admin_manual/release_notes/upgrade_to_27.html

@nickvergessen
Copy link
Member

/backport to stable27

@SystemKeeper
Copy link
Contributor Author

Please also update the nginx docs:

Done in nextcloud/documentation#11288

@susnux susnux added pending documentation This pull request needs an associated documentation update and removed pending documentation This pull request needs an associated documentation update labels Nov 16, 2023
@blizzz blizzz mentioned this pull request Nov 16, 2023
@SystemKeeper SystemKeeper merged commit db3c731 into master Nov 16, 2023
@SystemKeeper SystemKeeper deleted the fix/noid/serve-flac-files branch November 16, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants