Support call sounds on Safari #9422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @author Marco Ambrosini ([email protected]) | ||
| @license CC0-1.0 | ||
|
|
||
| ## join_call.flac |
Member
There was a problem hiding this comment.
you add 3 files but only 2 licenses?
Contributor
Author
There was a problem hiding this comment.
We did not specify a license for LibremPhoneCall.ogg before, so I did not add it for the FLAC version.
Contributor
Author
There was a problem hiding this comment.
@marcoambrosini any idea about the third license ?
Member
There was a problem hiding this comment.
No, that file was already there when I added the join and leave call sounds.
Signed-off-by: Marcel Müller <[email protected]>
SystemKeeper
force-pushed
the
bugfix/noid/support-call-sounds-on-safari
branch
from
c2fa67c to
45ddc6c
Compare
Signed-off-by: Marcel Müller <[email protected]>
Signed-off-by: Marcel Müller <[email protected]>
Signed-off-by: Marcel Müller <[email protected]>
SystemKeeper
force-pushed
the
bugfix/noid/support-call-sounds-on-safari
branch
from
45ddc6c to
acf5f2e
Compare
Contributor
Author
|
@nickvergessen Should this be backported? |
Member
|
I think it would be quite a surprise for most users in a patch release. We can of course bump the minor version to indicate something a like, but otherwise I'm also fine with not backporting |
Contributor
Author
|
/backport to stable27 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
Until now we don't support call sounds on Safari. This has 2 reasons:
To solve the first issue we also provide FLAC files for the sounds which are working fine on Safari. To solve the second issue we create the audio object when we press the start call button. As this is done inside of a click event handler, the audio objects are free to play at any time.
While this approach in theory also works iOS, it does not work anymore as soon as you grant camera and microphone permissions there - so we keep the note about it not being supported on those devices.
Follow-up to #5410
Tested on
🏁 Checklist
docs/has been updated or is not required