Synchronize operation on live photo files #41765
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artonge
added
2. developing
Contributor
Author
|
/backport to stable28 |
artonge
force-pushed
the
artonge/feat/sync_live_photos
branch
from
a464f22 to
56e501c
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
artonge
force-pushed
the
artonge/feat/sync_live_photos
branch
from
56e501c to
3c03c96
Compare
| $view->chroot($fakeRoot); | ||
| \OCP\Util::emitHook('\OCA\Files_Trashbin\Trashbin', 'post_restore', ['filePath' => Filesystem::normalizePath('/' . $location . '/' . $uniqueFilename), | ||
| 'trashPath' => Filesystem::normalizePath($file)]); | ||
| \OCP\Util::emitHook('\OCA\Files_Trashbin\Trashbin', 'post_restore', ['filePath' => $targetPath, 'trashPath' => $sourcePath]); |
Check notice
Code scanning / Psalm
DeprecatedMethod
artonge
force-pushed
the
artonge/feat/sync_live_photos
branch
3 times, most recently
from
de8842d to
fe81619
Compare
artonge
force-pushed
the
artonge/feat/sync_live_photos
branch
from
fe81619 to
8e45909
Compare
artonge
commented
Nov 29, 2023
artonge
force-pushed
the
artonge/feat/sync_live_photos
branch
5 times, most recently
from
35bf478 to
0f5b386
Compare
Signed-off-by: Louis Chemineau <[email protected]>
artonge
force-pushed
the
artonge/feat/sync_live_photos
branch
from
0f5b386 to
2f6a4bf
Compare
AndyScherzinger
approved these changes
Nov 29, 2023
artonge
added
the
pending documentation
artonge
commented
Nov 30, 2023
Contributor
Author
There was a problem hiding this comment.
Validate logic with what's expected by the user, and add it as a comment
Member
|
fixed milestone. master is 29. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds automatic management of live photos. This means that both file of a live photo will be kept in sync, if they are renamed, moved, or deleted.
A few extra changes were needed:
BeforeNodeRestoredEventevent to react to restore action from the trashbinNodeRestoredEvent, for completeness.apps/files_trashbin/lib/Trashbin.phpabortOperationmethod in bothBeforeNodeDeletedEventandBeforeNodeRenamedEventto allow an event listener to abort the operation.