[stable28] Synchronize operation on live photo files #41921
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Louis Chemineau <[email protected]>
backportbot-nextcloud
bot
added
feature: files
pending documentation
backportbot-nextcloud
bot
requested review from
AndyScherzinger,
ArtificialOwl and
artonge
artonge
approved these changes
Nov 30, 2023
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| $this->handleDeletion($event, $peerFile); | ||
| } elseif ($event instanceof CacheEntryRemovedEvent) { | ||
| $peerFile->delete(); | ||
| } elseif ($event instanceof BeforeNodeRestoredEvent) { |
Check failure
Code scanning / Psalm
RedundantCondition
| } | ||
|
|
||
| if ($event instanceof BeforeNodeRenamedEvent) { | ||
| $this->handleMove($event, $peerFile); |
Check notice
Code scanning / Psalm
ArgumentTypeCoercion
| if ($event instanceof BeforeNodeRenamedEvent) { | ||
| $this->handleMove($event, $peerFile); | ||
| } elseif ($event instanceof BeforeNodeDeletedEvent) { | ||
| $this->handleDeletion($event, $peerFile); |
Check notice
Code scanning / Psalm
ArgumentTypeCoercion
| } elseif ($event instanceof CacheEntryRemovedEvent) { | ||
| $peerFile->delete(); | ||
| } elseif ($event instanceof BeforeNodeRestoredEvent) { | ||
| $this->handleRestore($event, $peerFile); |
Check notice
Code scanning / Psalm
ArgumentTypeCoercion
| $event->abortOperation(new NotPermittedException("Cannot restore the video part of a live photo")); | ||
| } | ||
| } else { | ||
| $user = $this->userSession->getUser(); |
Check notice
Code scanning / Psalm
PossiblyNullReference
AndyScherzinger
approved these changes
Nov 30, 2023
artonge
force-pushed
the
backport/41765/stable28
branch
from
766e45e to
86d88f6
Compare
Contributor
|
CI failure unrelated |
skjnldsv
removed
the
pending documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #41765 and #41924