Always emit search event #41771
Merged
Always emit search event #41771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
reviewed
Nov 27, 2023
| this.results = [] | ||
| return | ||
| } | ||
| if (this.supportFiltering()) { |
Contributor
Author
There was a problem hiding this comment.
@juliushaertl the method is needed to make sure the "Filter in app" button for our own hard coded apps, show for now.
nfebe
force-pushed
the
always-emit-search-event
branch
from
33f07a5 to
aa66016
Compare
Member
|
/backport to stable28 |
For BOD, it's better to always emit the search event so apps (all of which we don't know) responding to this effect would receive notifications when the search happens within these apps. Signed-off-by: fenn-cs <[email protected]>
nfebe
force-pushed
the
always-emit-search-event
branch
from
aa66016 to
e99d7ba
Compare
AndyScherzinger
approved these changes
Nov 29, 2023
emoral435
approved these changes
Nov 29, 2023
Member
|
/backport to stable28 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For BOD, it's better to always emit the search event so apps (all of which we don't know) responding to this effect would receive notifications when the search happens within these apps.