Skip to content

Always emit search event #41771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndyScherzinger merged 1 commit into from
Nov 29, 2023
Merged

Always emit search event #41771

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions core/src/views/GlobalSearchModal.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,9 +255,8 @@ export default {
this.searching = false
return
}
if (this.supportFiltering()) {
Copy link
Member

@juliusknorr juliusknorr Nov 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also drop the method?

Copy link
Contributor Author

@nfebe nfebe Nov 27, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juliushaertl the method is needed to make sure the "Filter in app" button for our own hard coded apps, show for now.

emit('nextcloud:unified-search.search', { query })
}
// Event should probably be refactored at some point to used nextcloud:global-search.search
emit('nextcloud:unified-search.search', { query })
const newResults = []
const providersToSearch = this.filteredProviders.length > 0 ? this.filteredProviders : this.providers
const searchProvider = (provider, filters) => {
Expand Down
4 changes: 2 additions & 2 deletions dist/core-global-search.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/core-global-search.js.map
View file
Open in desktop

Large diffs are not rendered by default.