Skip to content

Conversation

@nfebe
Copy link
Contributor

@nfebe nfebe commented Nov 27, 2023

  • Use standard font of filter tags/chips
  • No bold
  • Use close icon and no close thick

#41651

@nfebe nfebe changed the title Improve accesibility for search tags/chips UI updates for global search Nov 27, 2023
@nfebe nfebe force-pushed the minor-ui-updates-global-search branch from 1f27342 to d886b51 Compare November 27, 2023 22:40
@nfebe
Copy link
Contributor Author

nfebe commented Nov 27, 2023

Before After
Screenshot from 2023-11-27 23-46-54 Screenshot from 2023-11-27 23-44-55
Screenshot from 2023-11-27 23-47-16 Screenshot from 2023-11-27 23-45-09

@nimishavijay

@nfebe nfebe force-pushed the minor-ui-updates-global-search branch from d886b51 to 2199f82 Compare November 28, 2023 14:27
@nfebe
Copy link
Contributor Author

nfebe commented Nov 28, 2023

/compile amend /

@nextcloud-command nextcloud-command force-pushed the minor-ui-updates-global-search branch from 2199f82 to 96c945d Compare November 28, 2023 15:03
@AndyScherzinger AndyScherzinger added this to the Nextcloud 29 milestone Nov 28, 2023
@nfebe nfebe force-pushed the minor-ui-updates-global-search branch 2 times, most recently from 743d76a to 4944c60 Compare November 28, 2023 16:08
@nfebe
Copy link
Contributor Author

nfebe commented Nov 28, 2023

/compile amend /

@nextcloud-command nextcloud-command force-pushed the minor-ui-updates-global-search branch from 4944c60 to 0275298 Compare November 28, 2023 16:37
@nfebe nfebe enabled auto-merge November 28, 2023 16:43
@AndyScherzinger AndyScherzinger mentioned this pull request Nov 29, 2023
3 tasks
- Use stand font of filter tags/chips
- No bold
- Use close icon and no close thick

Signed-off-by: fenn-cs <[email protected]>
@AndyScherzinger AndyScherzinger force-pushed the minor-ui-updates-global-search branch 2 times, most recently from fc2cdfb to d972e16 Compare November 29, 2023 10:45
@AndyScherzinger
Copy link
Member

/compile amend /

1 similar comment
@nfebe
Copy link
Contributor Author

nfebe commented Nov 29, 2023

/compile amend /

- Show loading when actually loading, instead of no content
- Change modified label to `Date` as it applies to a bunch of things.

Signed-off-by: fenn-cs <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@nextcloud-command nextcloud-command force-pushed the minor-ui-updates-global-search branch from d972e16 to 1534ba0 Compare November 29, 2023 12:24
@AndyScherzinger AndyScherzinger merged commit 8f7a138 into master Nov 29, 2023
@AndyScherzinger AndyScherzinger deleted the minor-ui-updates-global-search branch November 29, 2023 14:08
@AndyScherzinger
Copy link
Member

/backport to stable28

@blizzz
Copy link
Member

blizzz commented Nov 29, 2023

/backport to stable28

@blizzz
Copy link
Member

blizzz commented Nov 29, 2023

likely will not backport because of the compiled assets. if they were in a separate commit, only those can be picked with the source changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants